Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix blacklist/whitelist tests referring to wrong class #129

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Fix blacklist/whitelist tests referring to wrong class #129

merged 1 commit into from
Jun 4, 2018

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jun 4, 2018 •
edited
Loading

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@emerick emerick self-assigned this Jun 4, 2018
@emerick emerick requested a review from bbondy June 4, 2018 14:53
@bbondy
Copy link
Member

bbondy commented Jun 4, 2018

Thanks!

@bbondy bbondy merged commit 723e32e into master Jun 4, 2018
@bsclifton bsclifton deleted the fix-extension-provider-browsertest branch June 18, 2018 06:28
NejcZdovc pushed a commit that referenced this pull request Mar 6, 2019
@tmancey
Resolve Chromium build warnings (#129)
ecea107 
* Resolve auto variable type must not deduce to a raw pointer type Chromium warnings

* Resolve complex constructor has an inlined body Chromium warnings

* Add sources to BUILD.gn

* Remove temporary configs

* Added sources to CMakeLists.txt
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 3, 2019
@cezaraugusto @petemill
Update UI and remove legacy props from private tab page
c466f8a 
closes brave#129
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
@cezaraugusto
Imported from brave-ui: Update UI and remove legacy props from privat…
eaafc66 
…e tab page

closes brave#129
petemill pushed a commit that referenced this pull request Jul 5, 2019
@cezaraugusto @petemill
Imported from brave-ui: Update UI and remove legacy props from privat…
c075e56 
…e tab page

closes #129
fmarier pushed a commit that referenced this pull request Oct 29, 2019
@bbondy
Merge pull request #129 from brave/dockerfile
999758f 
Add lsb-release dependency which is used by install-build-deps.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@emerick emerick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emerick @bbondy