-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce wallet page routing complexity #13068
Conversation
A Storybook has been deployed to preview UI for the latest push |
2a70b94
to
0fec5f8
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled to test locally
Found some bugs that need to be addressed.
-
Session Route is not being persisted. (example: While the wallet is locked, enter the route
brave://wallet/crypto/accounts
, it will redirect you to unlock the wallet. After you unlock the wallet it should direct you tobrave://wallet/crypto/accounts
notbrave://wallet/crypto/portfolio
-
Add account
button is not working on theAsset Detail
page. -
While the wallet is unlocked go to
brave://wallet/crypto/portfolio/braveisawesome
, if the token doesn't exist it should redirect back tobrave://wallet/crypto/portfolio/
which it looks like it's trying to do, but/braveisawesome
stays persisted and theNav
bar disappears. -
Restore
button isn't working on thebrave://wallet/crypto/unlock
page -
Restore
button isn't working on thebrave://wallet/crypto/onboarding
page -
After creating a
password
for a newwallet
it shows thebackup-wallet
page but the route should bebrave://wallet/crypto/backup-wallet
-
After creating a
wallet
theskip
button isn't working on thebackup-wallet
page -
After creating a
wallet
therecovery phrase
is empty on the next step.
0fec5f8
to
31a4e39
Compare
A Storybook has been deployed to preview UI for the latest push |
78046e8
to
c27cddd
Compare
Fixed in commit: c27cddd |
f4b36bf
to
7b1736f
Compare
A Storybook has been deployed to preview UI for the latest push |
54d9cad
to
2f6d211
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
31b3f66
to
9fb9517
Compare
A Storybook has been deployed to preview UI for the latest push |
9fb9517
to
b531d7f
Compare
A Storybook has been deployed to preview UI for the latest push |
b531d7f
to
8e302d0
Compare
A Storybook has been deployed to preview UI for the latest push |
8e302d0
to
84564c7
Compare
A Storybook has been deployed to preview UI for the latest push |
84564c7
to
e387ce2
Compare
A Storybook has been deployed to preview UI for the latest push |
e387ce2
to
99d445a
Compare
A Storybook has been deployed to preview UI for the latest push |
Resolves brave/brave-browser#22402
Resolves brave/brave-browser#22588
Resolves brave/brave-browser#22589
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: