Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for empty attribute-value for ⚡ #13182

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

ShivanKaul
Copy link
Collaborator

@ShivanKaul ShivanKaul commented Apr 27, 2022

Resolves brave/brave-browser#22573

Add empty attribute check in regex for ⚡. We already have a check for amp. Also add unit tests.

cc @jonathansampson

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Going to https://shivankaul.com/brave/de-amp/test-amp-lightning-empty-attribute.html should navigate to https://brave.com with the De-AMP pref (in brave://settings/shields) turned on.
  2. If turned off, it should stay on https://shivankaul.com/brave/de-amp/test-amp-lightning-empty-attribute.html.
  3. This should happen on both Desktop and Android.

@ShivanKaul ShivanKaul added this to the 1.40.x - Nightly milestone Apr 27, 2022
@ShivanKaul ShivanKaul requested review from fmarier and iefremov April 27, 2022 04:32
@ShivanKaul ShivanKaul self-assigned this Apr 27, 2022
Copy link
Member

@fmarier fmarier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests look fine. I didn't really look at the regexp too closely :)

@ShivanKaul ShivanKaul force-pushed the bugfix/de-amp-regex-empty-amp-attribute branch 2 times, most recently from 6358ad0 to e78bd45 Compare April 28, 2022 00:49
@ShivanKaul ShivanKaul force-pushed the bugfix/de-amp-regex-empty-amp-attribute branch from e78bd45 to f648b5e Compare April 28, 2022 00:51
@ShivanKaul ShivanKaul merged commit ea44822 into master Apr 28, 2022
@ShivanKaul ShivanKaul deleted the bugfix/de-amp-regex-empty-amp-attribute branch April 28, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[De-AMP] Regex does not check for empty value of ⚡ attribute
3 participants