Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added valid resource id for task manager title when creating shields panel bubble #13367

Merged
merged 1 commit into from
May 18, 2022
Merged

Added valid resource id for task manager title when creating shields panel bubble #13367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/ui/views/brave_actions/brave_shields_action_view.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ void BraveShieldsActionView::ButtonPressed() {
if (!webui_bubble_manager_) {
webui_bubble_manager_ =
std::make_unique<WebUIBubbleManagerT<ShieldsPanelUI>>(
this, profile_, GURL(kShieldsPanelURL), 1);
this, profile_, GURL(kShieldsPanelURL), IDS_BRAVE_SHIELDS);
Copy link
Member

@simonhong simonhong May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I found that vpn panel also have same issue. - #13368

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking we should use "Brave Shields UI" so that people don't get confused and think this is a process for the actual shields work, and know this is for the UI renderer.

Copy link
Contributor Author

@nullhook nullhook May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name has "Tool: ..." as part of the string vs a process "GPU Process"

Copy link
Contributor Author

@nullhook nullhook May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do it as a follow up: brave/brave-browser#22924

}

if (webui_bubble_manager_->GetBubbleWidget()) {
Expand Down