-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardening is_enabled check for Ads Service #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
changed the title
Makes AdsService factory dependent upon RewardsServiceFactory
Makes AdsServiceFactory dependent upon RewardsServiceFactory
Jan 15, 2019
ryanml
changed the title
Makes AdsServiceFactory dependent upon RewardsServiceFactory
Hardening is_enabled check for Ads Service
Jan 15, 2019
bridiver
reviewed
Jan 15, 2019
ryanml
force-pushed
the
fix-2972
branch
2 times, most recently
from
January 15, 2019 23:56
bf2c660
to
efd8259
Compare
Adds pref for RewardsMainEnabled and factors that in to Ads Service start
bridiver
reviewed
Jan 16, 2019
bridiver
approved these changes
Jan 16, 2019
ryanml
added a commit
that referenced
this pull request
Jan 16, 2019
Hardening is_enabled check for Ads Service
Merged
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#2972
Undoes: #1337
This fix renders what was done in #1337 obsolete
Also migrates current rewards prefs in to their own namespace in
brave_rewards/common
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: