Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The content on brave://settings/braveHelpTips disappears upon reload and direct access via the address bar #14118

Merged
merged 2 commits into from
Jul 13, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jul 11, 2022

Resolves brave/brave-browser#22736

  • Fixed navigation issue with /braveHelpTips to create it inside ADVANCED as well as adjacent nodes.
  • Little refactoring from obsolete template generation to more fresh approach.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • same as in issue

Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

browser/resources/settings/brave_routes.js Show resolved Hide resolved
@spylogsster spylogsster merged commit 3491fa6 into master Jul 13, 2022
@spylogsster spylogsster deleted the brave-22736 branch July 13, 2022 05:45
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.43.20 Chromium: 103.0.5060.114 (Official Build) nightly (x86_64)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS macOS Version 13.0 (Build 22A5295i)

Tested both cases from the original testplan at brave/brave-browser#22736 (comment)

Case 1

  1. Open brave://settings/braveHelpTips via the address bar.
  2. Observe the content of the page.

Case 2

  1. Open brave://settings/.
  2. Click on Additional settings from the settings menu. (note: now expanded by default, in all Chromium versions since)
  3. Click on Help tips.
  4. Reload the page.

Confirmed defaults:

  • Show Wayback Machine prompt on 404 pages set to Enabled
  • Warn me before closing window with multiple tabs set to Enabled
  • Show warning before quitting with command-Q is set to Disabled
direct load of brave://settings/braveHelpTips Dark Light
Screenshot 2022-07-13 at 3 24 23 PM Screenshot 2022-07-13 at 3 19 54 PM Screenshot 2022-07-13 at 3 19 28 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The content on brave://settings/braveHelpTips disappears upon reload and direct access via the address bar
3 participants