Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear syncCodeValidationError on closing dialog #14308

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Clear syncCodeValidationError on closing dialog #14308

merged 1 commit into from
Jul 27, 2022

Conversation

sangwoo108
Copy link
Contributor

We should clear this property so that users don't see
an error message when they open the dialog again.

Resolves brave/brave-browser#23772

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Manual: the original issue has steps to reproduce.

We should clear this property so that users don't see
an error message when they open the dialog again.
@sangwoo108 sangwoo108 requested a review from petemill July 23, 2022 08:34
@sangwoo108 sangwoo108 marked this pull request as ready for review July 23, 2022 08:34
@sangwoo108
Copy link
Contributor Author

Hi @petemill ! Could you take a look at this? Thanks!

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangwoo108 sangwoo108 merged commit 81877a6 into master Jul 27, 2022
@sangwoo108 sangwoo108 deleted the sko/sync branch July 27, 2022 23:06
@github-actions github-actions bot added this to the 1.44.x - Nightly milestone Jul 27, 2022
@sangwoo108
Copy link
Contributor Author

Thank you for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error messages persist when clicked on I have a Sync Code button in the Sync Setup page
3 participants