Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync fix crash on QR code when keyring is locked (uplift to 1.43.x) #14825

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Sync fix crash on QR code when keyring is locked (uplift to 1.43.x) #14825

merged 1 commit into from
Aug 29, 2022

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented Aug 25, 2022 •
edited by kjozwiak
Loading

Uplift of #14224
Resolves brave/brave-browser#24121

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@AlexeyBarabash AlexeyBarabash self-assigned this Aug 25, 2022
@AlexeyBarabash AlexeyBarabash requested a review from a team as a code owner August 25, 2022 09:35
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Aug 25, 2022
@kjozwiak kjozwiak added this to the 1.43.x - Release milestone Aug 29, 2022
kjozwiak
kjozwiak approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.43.x approved 👍 QA has verified the PR on Nightly as per #14224 (comment).

@kjozwiak kjozwiak merged commit e7800ed into 1.43.x Aug 29, 2022
@kjozwiak kjozwiak deleted the pr14224_sync_warn_keyring_locked_1.43.x branch August 29, 2022 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@AlexeyBarabash AlexeyBarabash

Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Milestone
1.43.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexeyBarabash @kjozwiak