Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always fetch referral headers on startup #1493

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Jan 29, 2019

Fixes brave/brave-browser#3143

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@emerick emerick added this to the 0.62.x - Nightly milestone Jan 29, 2019
@emerick emerick self-assigned this Jan 29, 2019
Copy link
Member

@aekeus aekeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The call will be made on each installation regardless of promotion.

Copy link
Member

@aekeus aekeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The call will be made on each installation regardless of promotion.

@emerick emerick requested a review from mkarolin January 29, 2019 20:37
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emerick emerick merged commit 8305d50 into master Jan 29, 2019
@emerick emerick deleted the fix-referral-headers-download branch January 29, 2019 20:45
emerick added a commit that referenced this pull request Jan 29, 2019
Always fetch referral headers on startup
emerick added a commit that referenced this pull request Jan 29, 2019
Always fetch referral headers on startup
emerick added a commit that referenced this pull request Jan 29, 2019
Always fetch referral headers on startup
emerick added a commit that referenced this pull request Jan 29, 2019
Merge pull request #1493 from brave/fix-referral-headers-download
emerick added a commit that referenced this pull request Jan 29, 2019
Merge pull request #1493 from brave/fix-referral-headers-download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browser requires restart for "x-brave-partner" headers to start working
3 participants