Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CONNECTED publisher status (uplift to 1.45.x) #15176

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Deprecate CONNECTED publisher status (uplift to 1.45.x) #15176

merged 1 commit into from
Oct 4, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 22, 2022 •
edited by kjozwiak
Loading

Uplift of #15167
Resolves brave/brave-browser#25085

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 22, 2022 13:39
@brave-builds brave-builds self-assigned this Sep 22, 2022
@brave-builds brave-builds added this to the 1.45.x - Beta milestone Sep 22, 2022
@LaurenWags
Copy link
Member

Added PR/Blocked label per discussion in https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1664457997828209?thread_ts=1663856354.685349&cid=CHGKGMHDJ until follow up issue, brave/brave-browser#25699, is resolved.

cc @kjozwiak

@LaurenWags
Copy link
Member

Removing PR/Blocked as brave/brave-browser#25699 has been resolved via #15290 and verified per #15290 (comment). A separate uplift for this follow up issue has been created via #15308.

@Miyayes Miyayes mentioned this pull request Oct 4, 2022
Closed
kjozwiak
kjozwiak approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍 QA has verified the PR on Nightly as per #15167 (comment).

@kjozwiak kjozwiak merged commit 4502508 into 1.45.x Oct 4, 2022
@kjozwiak kjozwiak deleted the pr15167_ksmith-verified-publishers_1.45.x branch October 4, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @LaurenWags @kjozwiak @brave-browser-releases