Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards publisher list is now updated every 24 hours #1530

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Rewards publisher list is now updated every 24 hours #1530

merged 1 commit into from
Feb 4, 2019

Conversation

jasonrsadler
Copy link
Contributor

Original PR: #1524
Resolves brave/brave-browser#3134

Rewards publisher list is now updated every 24 hours
@jasonrsadler jasonrsadler self-assigned this Jan 31, 2019
@NejcZdovc NejcZdovc removed their request for review January 31, 2019 13:55
@NejcZdovc NejcZdovc added this to the 0.60.x - Beta milestone Jan 31, 2019
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 0.60.x approved after deliberating with @rebron. Also approved and discussed with @bbondy during the Rewards meeting. Please ensure that all associated issue(s) are adde into the correct milestone.

@NejcZdovc @jasonrsadler looks like the PR failed the pep8 checks. Approving but the pep8 failure should be fixed.

@jasonrsadler
Copy link
Contributor Author

pep8 was a blip. Reran and passed 👍
@kjozwiak @rebron @NejcZdovc

@jasonrsadler jasonrsadler merged commit 7b855c1 into brave:0.60.x Feb 4, 2019
@jasonrsadler jasonrsadler deleted the publisher-list-24-60 branch February 4, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants