Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux arm64 support (sans Widevine) #15349

Merged
merged 11 commits into from
Oct 12, 2022
Merged

Linux arm64 support (sans Widevine) #15349

merged 11 commits into from
Oct 12, 2022

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented Oct 5, 2022 •
edited
Loading

Resolves brave/brave-browser#11836. Widevine is not yet supported.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mherrmann mherrmann self-assigned this Oct 5, 2022
@mherrmann mherrmann marked this pull request as ready for review October 6, 2022 11:00
@mherrmann mherrmann requested review from a team and bridiver as code owners October 6, 2022 11:00
iefremov
iefremov reviewed Oct 6, 2022
View reviewed changes
app/linux/BUILD.gn Outdated Show resolved Hide resolved
bridiver
bridiver reviewed Oct 6, 2022
View reviewed changes
app/linux/BUILD.gn Outdated Show resolved Hide resolved
@mherrmann mherrmann force-pushed the support-linux-arm64 branch from f855d37 to 16415eb Compare October 7, 2022 08:34
@mherrmann mherrmann changed the title Support Arm64 Linux Support Arm64 Linux (sans Widevine) Oct 10, 2022
@mihaiplesa mihaiplesa changed the title Support Arm64 Linux (sans Widevine) Arm64 Linux support (sans Widevine) Oct 11, 2022
@mihaiplesa mihaiplesa changed the title Arm64 Linux support (sans Widevine) Linux arm64 support (sans Widevine) Oct 11, 2022
bridiver
bridiver reviewed Oct 11, 2022
View reviewed changes
app/linux/BUILD.gn Outdated Show resolved Hide resolved
@mherrmann
Fix Rust-related error building for Arm64 Linux
5ce1167
@mherrmann
Fix error building for Arm64 Linux
0e7776d
@mherrmann
Fix strip error when building for Arm64 Linux
ebc3ea6
@mherrmann
Fix lint errors
c8626d1
@mherrmann
Disable Widevine on Arm64 Linux
5a03ba0
@mherrmann
Move includes out of Widevine-specific build flag
3a08b19
@mherrmann
Simplify Linux build code
d87bd58 
Previously, `npm run build` produced out/brave with debug info. Then,
`npm run create_dist` modified that file to strip symbols.

Now, out/brave remains unchanged and we rely on Chromium's existing
logic for putting the stripped binary into the .deb and .rpm packages.
@mherrmann
Fix lint error
49df7c0
@mherrmann
Avoid duplicate symbol generation on Linux
458ab51
@mherrmann
Enable VA-API on Arm64 Linux
32ca54f
@mherrmann mherrmann force-pushed the support-linux-arm64 branch from 529ccb1 to 32ca54f Compare October 11, 2022 16:55
@mherrmann mherrmann mentioned this pull request Oct 12, 2022
Open
@mherrmann mherrmann requested a review from bridiver October 12, 2022 06:48
@mherrmann
Copy link
Collaborator Author

Thank you @bridiver 🙏

@mherrmann mherrmann enabled auto-merge (squash) October 12, 2022 15:29
@mherrmann mherrmann merged commit a361584 into master Oct 12, 2022
@mherrmann mherrmann deleted the support-linux-arm64 branch October 12, 2022 16:21
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 12, 2022
@theofficialgman theofficialgman mentioned this pull request Oct 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

@iefremov iefremov Awaiting requested review from iefremov

@bsclifton bsclifton Awaiting requested review from bsclifton

@simonhong simonhong Awaiting requested review from simonhong

Assignees

@mherrmann mherrmann

Labels
None yet
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging this pull request may close these issues.

Support for ARM64 on Linux?
3 participants
@mherrmann @bridiver @iefremov