-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Windows Group Policy templates for Brave #15440
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mherrmann
force-pushed
the
generate-group-policy-templates
branch
2 times, most recently
from
November 2, 2022 17:30
bcd8084
to
ff1f9ff
Compare
goodov
reviewed
Nov 4, 2022
patches/components-policy-tools-template_writers-template_formatter.py.patch
Outdated
Show resolved
Hide resolved
...um_src/python_modules/components/policy/tools/template_writers/brave_writer_configuration.py
Outdated
Show resolved
Hide resolved
mherrmann
force-pushed
the
generate-group-policy-templates
branch
from
November 5, 2022 19:12
7c8ca84
to
e993eef
Compare
Wdyt now @goodov? |
goodov
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks! pls fix few nits and we're good.
chromium_src/components/policy/tools/template_writers/writer_configuration.py
Show resolved
Hide resolved
patches/components-policy-tools-template_writers-writer_configuration.py.patch
Outdated
Show resolved
Hide resolved
chromium_src/components/policy/tools/template_writers/writer_configuration.py
Outdated
Show resolved
Hide resolved
goodov
reviewed
Nov 7, 2022
goodov
reviewed
Nov 7, 2022
The templates (*.adm, *.admx) can be generated via: npm run build -- --target=components/policy:policy_templates This places them in `out\Component\gen\chrome\app\policy\windows`.
It doesn't work and isn't worth the effort to fix.
mherrmann
force-pushed
the
generate-group-policy-templates
branch
from
November 7, 2022 10:40
d9154e9
to
3018c40
Compare
brave-builds
pushed a commit
that referenced
this pull request
Nov 8, 2022
brave-builds
pushed a commit
that referenced
this pull request
Nov 8, 2022
This was referenced Nov 8, 2022
goodov
reviewed
Nov 8, 2022
This was referenced Nov 8, 2022
Not sure how I missed this - but amazing work @mherrmann! 😄 This is something we've wanted for a long time! ❤️ |
Thanks! |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the documentation for Group Policies, we advise administrators to download Chrome's
policy_templates.zip
and modify it by hand for Brave's registry paths. This PR adds a target for generating our own, branded templates.Resolves brave/brave-browser#26501. Needs https://github.com/brave/devops/issues/2468 for upload to the web site and GitHub during releases.
Status
It's possible to generate the browser templates when building on Windows via:
They get placed in
brave_policy_templates.zip
.Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Download and extract Brave's
policy_templates.zip
. After https://github.com/brave/devops/issues/2468, this should be available from the web site and the GitHub releases page. Extract it. Open the Windows Group Policy editor. Rightclick Administrative Templates. Select Add/Remove Templates. Click Add and selectwindows/adm/en-US/brave.adm
from the Zip file. After this step, you should see Brave's settings in the Policy Editor. Modify a setting. Openbrave://policy
and make sure the setting you modified shows up there. You could also perform a functional test that the changed setting really has an effect.