Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Windows Group Policy templates for Brave #15440

Merged
merged 27 commits into from
Nov 7, 2022

Conversation

mherrmann
Copy link
Collaborator

@mherrmann mherrmann commented Oct 12, 2022

In the documentation for Group Policies, we advise administrators to download Chrome's policy_templates.zip and modify it by hand for Brave's registry paths. This PR adds a target for generating our own, branded templates.

Resolves brave/brave-browser#26501. Needs https://github.com/brave/devops/issues/2468 for upload to the web site and GitHub during releases.

Status

It's possible to generate the browser templates when building on Windows via:

npm run build -- --target=brave/components/policy:pack_policy_templates

They get placed in brave_policy_templates.zip.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Download and extract Brave's policy_templates.zip. After https://github.com/brave/devops/issues/2468, this should be available from the web site and the GitHub releases page. Extract it. Open the Windows Group Policy editor. Rightclick Administrative Templates. Select Add/Remove Templates. Click Add and select windows/adm/en-US/brave.adm from the Zip file. After this step, you should see Brave's settings in the Policy Editor. Modify a setting. Open brave://policy and make sure the setting you modified shows up there. You could also perform a functional test that the changed setting really has an effect.

@mherrmann mherrmann self-assigned this Oct 12, 2022
@mherrmann mherrmann force-pushed the generate-group-policy-templates branch 2 times, most recently from bcd8084 to ff1f9ff Compare November 2, 2022 17:30
@mherrmann mherrmann marked this pull request as ready for review November 2, 2022 17:44
@mherrmann mherrmann requested review from a team as code owners November 2, 2022 17:44
@mherrmann mherrmann force-pushed the generate-group-policy-templates branch from 7c8ca84 to e993eef Compare November 5, 2022 19:12
@mherrmann mherrmann requested a review from goodov November 5, 2022 19:15
@mherrmann
Copy link
Collaborator Author

Wdyt now @goodov?

Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks! pls fix few nits and we're good.

BUILD.gn Outdated Show resolved Hide resolved
@mherrmann mherrmann force-pushed the generate-group-policy-templates branch from d9154e9 to 3018c40 Compare November 7, 2022 10:40
@mherrmann mherrmann merged commit ac63b68 into master Nov 7, 2022
@mherrmann mherrmann deleted the generate-group-policy-templates branch November 7, 2022 14:00
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 7, 2022
@wknapik wknapik restored the generate-group-policy-templates branch November 8, 2022 01:39
brave-builds pushed a commit that referenced this pull request Nov 8, 2022
brave-builds pushed a commit that referenced this pull request Nov 8, 2022
@wknapik wknapik deleted the generate-group-policy-templates branch November 8, 2022 01:41
@bsclifton
Copy link
Member

Not sure how I missed this - but amazing work @mherrmann! 😄 This is something we've wanted for a long time! ❤️

@mherrmann
Copy link
Collaborator Author

Thanks! ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Windows Group Policy templates for Brave
3 participants