Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave News Source Suggestions #15447

Merged
merged 10 commits into from
Oct 18, 2022
Merged

Brave News Source Suggestions #15447

merged 10 commits into from
Oct 18, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Oct 13, 2022

Resolves brave/brave-browser#25563

Limitations

This PR isn't a complete implementation of suggestions, but I think it's a good first pass, and provides sensible suggestions. I'm documenting a few of the limitations here:

  • Suggestions are based only on:
    a) Whether a source has been visited
    b) How similar a source is to subscribed sources.
    c) How similar a source is to visited sources.
  • Only the users current locale is used for suggestions. In future we should be able to incrementally improve this.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable the brave://flags/#brave-news-v2 flag
  2. Subscribe to the The Drive publisher
  3. Reload the new tab page
  4. In the Brave News dialog there should be a suggestions row. It should include (if the similarity matrix hasn't been changed), PopularMechanics, Forbes, Car and Driver. Suggestions may (or may not) be slightly different

@petemill petemill force-pushed the news2ui branch 7 times, most recently from 1d4af76 to fb9b2b1 Compare October 15, 2022 18:09
Base automatically changed from news2ui to master October 15, 2022 19:17
@fallaciousreasoning fallaciousreasoning force-pushed the bn-suggestions branch 2 times, most recently from 5086626 to 69a0d4e Compare October 17, 2022 00:29
@fallaciousreasoning fallaciousreasoning marked this pull request as ready for review October 17, 2022 00:30
@petemill petemill changed the title Brave News Suggestions Draft Brave News Source Suggestions Oct 18, 2022
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working pretty nicely! Just some minor nits.

components/brave_today/browser/suggestions_controller.cc Outdated Show resolved Hide resolved
base::Unretained(this), std::move(callback)));
}

void SuggestionsController::GetSuggestedPublisherIdsWithHistory(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps either this function and/or GetVisitWeightings could do with some unit tests

@petemill
Copy link
Member

I ended up fixing some of these minor nits, because I had everything open - hope you don't mind!

@petemill petemill enabled auto-merge (squash) October 18, 2022 19:52
@petemill petemill merged commit 05f4c58 into master Oct 18, 2022
@petemill petemill deleted the bn-suggestions branch October 18, 2022 20:23
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add source suggestions for Brave News
2 participants