Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RASEO2_ReconnectIfDropped option for BraveVPN #15453

Merged
merged 1 commit into from
Oct 14, 2022
Merged

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 13, 2022

Resolves brave/brave-browser#24331

Removed RAS auto-reconnection option for Brave VPN because we duplicate this logic on BraveVPN service level and it conflicts in some cases because the connection stays busy and we are not able to change its state.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Steps from issue

@spylogsster spylogsster self-assigned this Oct 13, 2022
@spylogsster spylogsster changed the title Remove autoreconnection RAS option for BraveVPN Remove RASEO2_ReconnectIfDropped option for BraveVPN Oct 13, 2022
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@spylogsster spylogsster merged commit bcacaa9 into master Oct 14, 2022
@spylogsster spylogsster deleted the brave-24331 branch October 14, 2022 05:49
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 14, 2022
bsclifton pushed a commit that referenced this pull request Oct 20, 2022
Remove autoreconnection RAS option for BraveVPN
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants