Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable prerender test #15481

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Disable prerender test #15481

merged 3 commits into from
Oct 17, 2022

Conversation

goodov
Copy link
Member

@goodov goodov commented Oct 17, 2022

Disable ShareServicePrerenderBrowserTest.* tests and move other Prerender tests into one filter group.

Prerender2 feature check location:
https://github.com/chromium/chromium/blob/ad5e0113d5555689046ca1cd4f35949d204e4d0a/content/browser/preloading/prerender/prerender_host_registry.cc#L106-L110

Resolves https://github.com/brave/internal/issues/916
Resolves brave/brave-browser#26030

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goodov goodov merged commit 5d356cc into master Oct 17, 2022
@goodov goodov deleted the issues/916 branch October 17, 2022 13:30
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: ShareServicePrerenderBrowserTest.Text
2 participants