Reconnect when DNS is restored #15506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
reviewed
Oct 18, 2022
| VLOG(2) << __func__ << " Should reconnect:" << reconnect_on_resume_; | ||
| if (reconnect_on_resume_) { | ||
| Connect(); | ||
| reconnect_on_resume_ = false; |
There was a problem hiding this comment.
Instead of clearing reconnect_on_resme_ here, how about doing it in Connect()?
There was a problem hiding this comment.
Connect can be called from another places and drop this flag, this actually happens with need_reconnect_ in old solution
simonhong
approved these changes
Oct 18, 2022
| VLOG(2) << __func__ << " Should reconnect:" << reconnect_on_resume_; | ||
| if (reconnect_on_resume_) { | ||
| Connect(); | ||
| reconnect_on_resume_ = false; |
|
|
||
| void BraveVpnService::OnDNSChanged() { | ||
| if (!IsNetworkAvailable() || | ||
| // This event is triggered before going to sleep while vpn is still |
There was a problem hiding this comment.
nti: I think comments should be located before the if clause instead of between each condition.
There was a problem hiding this comment.
This comment explains why we add that second condition, will change in next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#25773
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: