Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations for Brave News channel names #15525

Merged
merged 6 commits into from
Oct 25, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#26116

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable the Brave News V2 flag
  2. In a non-English locale, open the Brave News configure dialog
  3. Channels should be translated

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 19, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Base automatically changed from bn-channel-icons to master October 20, 2022 02:10
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -86,7 +87,7 @@ export function ChannelListEntry (props: { channelId: string }) {
const { setSubscribed } = useChannelSubscribed(props.channelId)

return <Container direction="row" justify='space-between' align='center'>
<ChannelNameText>{props.channelId}</ChannelNameText>
<ChannelNameText>{getTranslatedChannelName(props.channelId)}</ChannelNameText>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q. Can we rename props.channelId to props.channelName? The id seems to be used as name as well but I think renaming would be good 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed! Mind taking another look?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning
Copy link
Contributor Author

I've renamed the remaining channelIds to channelNames - mind taking another look?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM! Thanks :)

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit 95d09a5 into master Oct 25, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-channel-translations branch October 25, 2022 00:11
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Oct 25, 2022
@stephendonner
Copy link
Contributor

@fallaciousreasoning just to be sure, these are what you're referring to, right?

Bildschirmfoto 2022-11-02 um 10 41 44 AM

@mkarolin will we have to wait until near-end of this release cycle, to be able to test these translations, if you know?

@fallaciousreasoning
Copy link
Contributor Author

Yup, those are the ones :)

@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.47.48 Chromium: 107.0.5304.91 (Build oficial) nightly (x86_64)
Revisión 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
SO macOS Versión 13.1 (Fase 22C5033e)

Steps:

  1. set my macOS system language to Spanish
  2. installed 1.47.48
  3. launched Brave
  4. opened brave://flags
  5. set brave://flags/#brave-news-v2 to Enabled
  6. clicked Relaunch
  7. opened a new-tab page
  8. clicked on Customize
  9. clicked on Brave News
  10. examined the Customize Brave News dialog

Confirmed the start of translated channel names, e.g. Crypto -> Criptomonedas in the dialog

Captura de pantalla 2022-11-05 a la(s) 10 19 41 a m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channels in Brave News are not translated
4 participants