-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translations for Brave News channel names #15525
Conversation
A Storybook has been deployed to preview UI for the latest push |
A Storybook has been deployed to preview UI for the latest push |
140bfcb
to
3b52189
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@@ -86,7 +87,7 @@ export function ChannelListEntry (props: { channelId: string }) { | |||
const { setSubscribed } = useChannelSubscribed(props.channelId) | |||
|
|||
return <Container direction="row" justify='space-between' align='center'> | |||
<ChannelNameText>{props.channelId}</ChannelNameText> | |||
<ChannelNameText>{getTranslatedChannelName(props.channelId)}</ChannelNameText> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q. Can we rename props.channelId to props.channelName? The id seems to be used as name as well but I think renaming would be good 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed! Mind taking another look?
A Storybook has been deployed to preview UI for the latest push |
I've renamed the remaining |
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still LGTM! Thanks :)
f6b201d
to
7c17110
Compare
A Storybook has been deployed to preview UI for the latest push |
@fallaciousreasoning just to be sure, these are what you're referring to, right? @mkarolin will we have to wait until near-end of this release cycle, to be able to test these translations, if you know? |
Yup, those are the ones :) |
Verified
|
Brave | 1.47.48 Chromium: 107.0.5304.91 (Build oficial) nightly (x86_64) |
---|---|
Revisión | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
SO | macOS Versión 13.1 (Fase 22C5033e) |
Steps:
- set my macOS system language to
Spanish
- installed
1.47.48
- launched Brave
- opened
brave://flags
- set
brave://flags/#brave-news-v2
toEnabled
- clicked
Relaunch
- opened a new-tab page
- clicked on
Customize
- clicked on
Brave News
- examined the
Customize Brave News
dialog
Resolves brave/brave-browser#26116
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: