Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add popular sources section to Brave News #15609

Merged
merged 5 commits into from
Nov 2, 2022
Merged

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Oct 24, 2022

Resolves brave/brave-browser#24324

Note: This PR doesn't add a new page like the issue and the UX design, it simply adds the same UI as the Suggestions section. I think we need to have a chat with the UX folks about exactly how this should work.

Popular sources, default
image

Popular sources, more loaded
image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable the Brave News V2 flag
  2. In the customize brave news dialog, there should be a popular sources section.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 24, 2022
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the design or spec calls for a single-row "carousel" which has a "view all" button that changes the "page" being viewed to being only all the sources ordered by popularity. However, this version with the "Show more" button will still work well as a first iteration, especially when we remove the "All sources" section at the bottom.

Apart from one small piece of feedback, this works well and seems ready.

@fallaciousreasoning
Copy link
Contributor Author

Yeah, I deliberately didn't build that new UI because things seemed a little unsettled there and a bit inconsistent. I think now we have a bit more clarity (don't show all feeds on the main page, show all channels, carousels, settled ordering) I think we're ready for an update.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.47.47 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 13.1 (Build 22C5033e)
  1. installed 1.47.47
  2. launched Brave
  3. clicked on Skip welcome tour
  4. opened brave://flags
  5. set brave://flags/#brave-news-v2 to Enabled
  6. clicked on Relaunch
  7. opened a new-tab page
  8. clicked on Customize
  9. clicked on Brave News
  10. clicked on Turn on Brave News
  11. clicked on Show more beneath Popular

Confirmed clicking on Show more on the Popular sources section expanded to show me them all

Light Dark
Screenshot 2022-11-05 at 2 51 40 AM Screenshot 2022-11-05 at 2 52 29 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave News Popular Sources Recommendations
4 participants