-
Notifications
You must be signed in to change notification settings - Fork 892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add popular sources section to Brave News #15609
Conversation
113a20c
to
8a44a26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the design or spec calls for a single-row "carousel" which has a "view all" button that changes the "page" being viewed to being only all the sources ordered by popularity. However, this version with the "Show more" button will still work well as a first iteration, especially when we remove the "All sources" section at the bottom.
Apart from one small piece of feedback, this works well and seems ready.
components/brave_new_tab_ui/components/default/braveToday/customize/Popular.tsx
Outdated
Show resolved
Hide resolved
8a44a26
to
d6bb7e5
Compare
Yeah, I deliberately didn't build that new UI because things seemed a little unsettled there and a bit inconsistent. I think now we have a bit more clarity (don't show all feeds on the main page, show all channels, carousels, settled ordering) I think we're ready for an update. |
A Storybook has been deployed to preview UI for the latest push |
Verified
|
Brave | 1.47.47 Chromium: 107.0.5304.91 (Official Build) nightly (x86_64) |
---|---|
Revision | 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097} |
OS | macOS Version 13.1 (Build 22C5033e) |
- installed
1.47.47
- launched Brave
- clicked on
Skip welcome tour
- opened
brave://flags
- set
brave://flags/#brave-news-v2
toEnabled
- clicked on
Relaunch
- opened a new-tab page
- clicked on
Customize
- clicked on
Brave News
- clicked on
Turn on Brave News
- clicked on
Show more
beneathPopular
Confirmed clicking on Show more
on the Popular
sources section expanded to show me them all
Light |
Dark |
---|---|
Resolves brave/brave-browser#24324
Note: This PR doesn't add a new page like the issue and the UX design, it simply adds the same UI as the Suggestions section. I think we need to have a chat with the UX folks about exactly how this should work.
Popular sources, default
Popular sources, more loaded
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: