Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News] Look for missing favicons in the FaviconService #15667

Merged
merged 9 commits into from
Nov 6, 2022

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Oct 26, 2022

Resolves brave/brave-browser#26266

Brave News Direct sources, with favicons
image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Enable Brave News V2
  2. Visit a page with a direct source (I like using https://reactjs.org/)
  3. Add the direct source to Brave News
  4. The source should have an icon

@fallaciousreasoning fallaciousreasoning self-assigned this Oct 26, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 26, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished reviewing and testing, but just wanted to give initial feedback first

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning
Copy link
Contributor Author

@petemill how does this look to you?

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@@ -16,6 +18,46 @@ interface Options {
}

const cache: { [url: string]: string } = {}
function useFavicon (publisherId: string | undefined) {
const [url, setUrl] = React.useState<string>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I wonder if it avoids a re-render for subsequent (different) calls to useFavicon with the same publisherId if we initialize this state variable to the potential cache version, i.e. ... = React.useState(cache[publisherId])

components/common/useVisible.ts Show resolved Hide resolved
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ 👍🏼

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit 74f708a into master Nov 6, 2022
@fallaciousreasoning fallaciousreasoning deleted the bn-favicons branch November 6, 2022 20:52
@kjozwiak
Copy link
Member

kjozwiak commented Nov 9, 2022

Verification's on Nightly were completed via #15820 (comment) before uplifting the above into 1.46.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Brave News] Brave News should check the favicon cache if a publisher doesn't have an icon
5 participants