Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle order update without parent changes #1572

Merged
merged 2 commits into from
Feb 5, 2019
Merged

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Feb 4, 2019

fix brave/brave-browser#3216

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Contributor

@AlexeyBarabash AlexeyBarabash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@darkdh darkdh added this to the 0.62.x - Nightly milestone Feb 5, 2019
@darkdh darkdh merged commit d4e7bda into master Feb 5, 2019
@darkdh darkdh deleted the sync-bookmark-swap branch February 5, 2019 18:54
darkdh added a commit that referenced this pull request Feb 6, 2019
Handle order update without parent changes
darkdh added a commit that referenced this pull request Feb 6, 2019
Handle order update without parent changes
darkdh added a commit that referenced this pull request Feb 14, 2019
Merge pull request #1572 from brave/sync-bookmark-swap
darkdh added a commit that referenced this pull request Feb 14, 2019
Merge pull request #1572 from brave/sync-bookmark-swap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bookmarks order changes under same folder doesn't work
2 participants