Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves # 26223 - Made 'crypto' lowercase on editcard widgets #15720

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Resolves # 26223 - Made 'crypto' lowercase on editcard widgets #15720

merged 1 commit into from
Nov 1, 2022

Conversation

UsmanAhmadSaeed
Copy link
Contributor

@UsmanAhmadSaeed UsmanAhmadSaeed commented Oct 31, 2022

Resolves brave/brave-browser#26223 - Made the word 'crypto' lowercase on edit card popups' cards section -> widgets' preview on new tab page

Resolves Issue #26223

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Resolves # 26223 - Made 'crypto' lowercase on edit card popups' cards section -> widgets' preview on new tab page
@bsclifton
Copy link
Member

Adding @mkarolin and @emerick as reviewers to make sure this is done in the right place 😄

To me - it looks 100% correct. But just wanted to verify as our localization process can be a bit wild

@UsmanAhmadSaeed
Copy link
Contributor Author

@bsclifton thanks! As easy as it seems, had to go through quite a lot of components and content to find what links where and where the value was coming from 😂
P.S. Meanwhile, could you add the hacktoberfest-accepted label to the PR, please?
Thanks

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton bsclifton added this to the 1.47.x - Nightly milestone Nov 1, 2022
@bsclifton bsclifton merged commit c7da5f2 into brave:master Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crypto should be lowercase on Gemini and Binance widget previews
4 participants