-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet): Dont Show Aurora in Ethereum Submenu #15973
Merged
Douglashdaniel
merged 1 commit into
master
from
fix-dont-show-aurora-in-ethereum-submenu
Nov 17, 2022
Merged
fix(wallet): Dont Show Aurora in Ethereum Submenu #15973
Douglashdaniel
merged 1 commit into
master
from
fix-dont-show-aurora-in-ethereum-submenu
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
Deploy storybook and provide a unique URL for each build
label
Nov 16, 2022
muliswilliam
approved these changes
Nov 16, 2022
A Storybook has been deployed to preview UI for the latest push |
onyb
reviewed
Nov 16, 2022
components/brave_wallet_ui/components/desktop/network-filter-selector/index.tsx
Outdated
Show resolved
Hide resolved
onyb
reviewed
Nov 16, 2022
components/brave_wallet_ui/components/desktop/network-filter-selector/index.tsx
Outdated
Show resolved
Hide resolved
Douglashdaniel
force-pushed
the
fix-dont-show-aurora-in-ethereum-submenu
branch
from
November 16, 2022 21:26
ef173c0
to
15c038a
Compare
A Storybook has been deployed to preview UI for the latest push |
onyb
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where
Aurora
was being listed underEthereum
submenuResolves brave/brave-browser#26813
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Network
filter and hover overEthereum
Aurora
should not be listed in theSubmenu
Before:
Screen.Recording.2022-11-16.at.10.33.48.AM.mov
After:
Screen.Recording.2022-11-16.at.10.36.27.AM.mov