-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Brave News] Don't allow duplicate items in the feed #15984
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c3350a5
to
9ce51e6
Compare
Remove channels in the empty locale
fe2a33f
to
3981348
Compare
dea70b9
to
65a9bdc
Compare
65a9bdc
to
292d6b9
Compare
petemill
approved these changes
Nov 18, 2022
petemill
added a commit
that referenced
this pull request
Nov 18, 2022
[Brave News] Don't allow duplicate items in the feed
Verified
|
Brave | 1.47.90 Chromium: 108.0.5359.48 (Official Build) nightly (64-bit) |
---|---|
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854} |
OS | Windows 10 Version 22H2 (Build 19045.2311) |
Steps:
- installed
1.47.90
- launched Brave
- opened a new-tab page
- scrolled down
- clicked on
Customize
- followed
CNN
,Techcrunch
, andCNN - World News
feeds - scrolled through my Brave News feed
Confirmed no feed-article duplicates
example | example | example |
---|---|---|
![]() |
![]() |
![]() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#26596
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Subscribe to CNN World News & TechCrunch. TechCrunch articles should not be duplicated.