Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News] Don't allow duplicate items in the feed #15984

Merged
merged 6 commits into from
Nov 18, 2022
Merged

Conversation

fallaciousreasoning
Copy link
Contributor

Resolves brave/brave-browser#26596

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Subscribe to CNN World News & TechCrunch. TechCrunch articles should not be duplicated.

@petemill petemill merged commit f5f0da2 into master Nov 18, 2022
@petemill petemill deleted the bn-dupe-feed branch November 18, 2022 06:56
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 18, 2022
petemill added a commit that referenced this pull request Nov 18, 2022
[Brave News] Don't allow duplicate items in the feed
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.47.90 Chromium: 108.0.5359.48 (Official Build) nightly (64-bit)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS Windows 10 Version 22H2 (Build 19045.2311)

Steps:

  1. installed 1.47.90
  2. launched Brave
  3. opened a new-tab page
  4. scrolled down
  5. clicked on Customize
  6. followed CNN, Techcrunch, and CNN - World News feeds
  7. scrolled through my Brave News feed

Confirmed no feed-article duplicates

example example example
duplicate1 duplicate2 duplicate3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate content appearing in feed
3 participants