Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Solana transaction based on selected account instead of fee payer #16154

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Nov 29, 2022

Resolves brave/brave-browser#27051

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The specific use case has been covered by new browser/unit tests.
For manual testing, please try Sign and Send Transaction in https://pwgoom.csb.app/ for a basic regression test with both software and hardware account(ledger).

@yrliou yrliou requested a review from a team as a code owner November 29, 2022 22:40
Copy link
Member

@darkdh darkdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@yrliou yrliou merged commit 5712ba6 into master Nov 30, 2022
@yrliou yrliou deleted the sign_solana_tx_with_selected_acc branch November 30, 2022 18:18
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Nov 30, 2022
yrliou added a commit that referenced this pull request Dec 1, 2022
Sign Solana transaction based on selected account instead of fee payer
brave-builds pushed a commit that referenced this pull request Dec 1, 2022
@srirambv
Copy link
Contributor

srirambv commented Dec 2, 2022

Verification passed on

Brave 1.48.23 Chromium: 108.0.5359.71 (Official Build) nightly (64-bit)
Revision 1e0e3868ee06e91ad636a874420e3ca3ae3756ac-refs/branch-heads/5359@{#1016}
OS Windows 11 Version 22H2 (Build 22623.1020)
  • Verified steps from PR
  • Verified able to submit a Sign and Send transaction
  • Verified able to submit and confirm transaction on both software and hardware wallet
16154.mov

Verification passed on Oppo Reno 5 with Android 12 running 1.48.23 x64 Nightly build

  • Verified able to submit a sign and send transaction
16154-ARM.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sign Solana transaction with selected account instead of fee payer
3 participants