Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Brave Ads endpoints from v2 to v3 #16273

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Change Brave Ads endpoints from v2 to v3 #16273

merged 1 commit into from
Dec 12, 2022

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Dec 7, 2022

Resolves brave/brave-browser#27211

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Confirm the following endpoints have v3:

GET /v3/issuers/
PUT /v3/confirmation/payment/{paymentId}
POST /v3/confirmation/{transactionId}/{credential}
GET /v3/confirmation/{transactionId}/paymentToken
GET /v3/confirmation/token/{paymentId}?nonce={nonce}
POST /v3/confirmation/token/{paymentId}

@tmancey tmancey requested a review from tackley December 7, 2022 10:56
@tmancey tmancey self-assigned this Dec 7, 2022
@tmancey tmancey requested a review from a team as a code owner December 7, 2022 10:56
Copy link

@tackley tackley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tackley
Copy link

tackley commented Dec 12, 2022

Just to confirm: all those v3 endpoints are live and running in production now. They're currently identical in behaviour to the v2 ones, but I'll be adding the new issuers in later this week.

@tmancey tmancey enabled auto-merge December 12, 2022 14:21
@tmancey tmancey merged commit 255bd99 into master Dec 12, 2022
@tmancey tmancey deleted the issues/27211 branch December 12, 2022 14:58
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Brave Ads endpoints from v2 to v3
3 participants