Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide first run dialog #16282

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Hide first run dialog #16282

merged 1 commit into from
Dec 8, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 8, 2022

Temporarily hide till we have numbers from new welcome flow.
If welcome flow do better than FR dialog, we'll delete FR dialog.

Resolves brave/brave-browser#27225

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch Brave with clean profile
  2. Check first run dialog is not launched

fix brave/brave-browser#27225

Temporarily hide till we have numbers from new welcome flow.
If welcome flow do better than FR dialog, we'll delete FR dialog.
@simonhong simonhong self-assigned this Dec 8, 2022
@simonhong simonhong marked this pull request as ready for review December 8, 2022 01:48
@simonhong simonhong requested a review from a team as a code owner December 8, 2022 01:48
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

⚠️ PR head is an unsigned commit
commit: 55e172e
reason: unsigned
Please follow the handbook to configure commit signing
cc: @simonhong

@simonhong simonhong merged commit c888547 into master Dec 8, 2022
@simonhong simonhong deleted the hide_first_run_dialog branch December 8, 2022 13:28
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 8, 2022
brave-builds pushed a commit that referenced this pull request Dec 8, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Dec 15, 2022

Reproduced the original behaviour on Win 11 x64 using the following build(s):

Brave | 1.48.38 Chromium: 108.0.5359.99 (Official Build) nightly (64-bit) 
--- | ---
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 11 Version 22H2 (Build 22621.963)

Using the STR/Cases outlined via #16282 (comment), reproduced the original behaviour as per the following:

reproducedDialog

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.48.57 Chromium: 108.0.5359.128 (Official Build) nightly (64-bit)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | Windows 11 Version 22H2 (Build 22621.963)

Using the STR/Cases outlined via #16282 (comment), verified that the default browser modal wasn't being displayed when Brave is initially installed.


Reproduced the original behaviour on macOS 13.0.1 Ventura x64 using the following build(s):

Brave | 1.48.38 Chromium: 108.0.5359.99 (Official Build) nightly (x86_64)
--- | ---
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | macOS Version 13.0.1 (Build 22A400)

Using the STR/Cases outlined via #16282 (comment), reproduced the original behaviour as per the following:

Screenshot 2022-12-14 at 11 48 46 PM

Verification PASSED on macOS 13.0.1 Ventura x64 using the following build(s):

Brave | 1.48.57 Chromium: 108.0.5359.128 (Official Build) nightly (x86_64)
--- | ---
Revision | 1cd27afdb8e5d057070c0961e04c490d2aca1aa0-refs/branch-heads/5359@{#1185}
OS | macOS Version 13.0.1 (Build 22A400)

Using the STR/Cases outlined via #16282 (comment), verified that the default browser modal wasn't being displayed when Brave is initially installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable first run dialog temporarily
3 participants