Web3 settings section #16290
Merged
Web3 settings section #16290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
supermassive
force-pushed
the
web3_settings_section
branch
2 times, most recently
from
54c7c0f to
04cc607
Compare
goodov
approved these changes
Dec 8, 2022
|
|
|
A Storybook has been deployed to preview UI for the latest push |
supermassive
force-pushed
the
web3_settings_section
branch
from
04cc607 to
d71c32f
Compare
yrliou
approved these changes
Dec 9, 2022
|
A Storybook has been deployed to preview UI for the latest push |
supermassive
force-pushed
the
web3_settings_section
branch
from
d71c32f to
5ed2124
Compare
|
A Storybook has been deployed to preview UI for the latest push |
petemill
approved these changes
Dec 15, 2022
Comment on lines
+278
to
+305
| let last = basicPageEl.insertAdjacentElement('afterbegin', | ||
| sectionGetStarted) | ||
| // Move Appearance item | ||
| const sectionAppearance = getSectionElement(actualTemplate.content, 'appearance') | ||
| sectionGetStarted.insertAdjacentElement('afterend', sectionAppearance) | ||
| const sectionAppearance = getSectionElement(actualTemplate.content, | ||
| 'appearance') | ||
| last = last.insertAdjacentElement('afterend', sectionAppearance) | ||
| // Insert New Tab | ||
| sectionAppearance.insertAdjacentElement('afterend', sectionNewTab) | ||
| last = last.insertAdjacentElement('afterend', sectionNewTab) | ||
| // Insert shields | ||
| sectionNewTab.insertAdjacentElement('afterend', sectionShields) | ||
| // Insert Rewards and Social Blocking | ||
| if (isBraveRewardsSupported) { | ||
| sectionShields.insertAdjacentElement('afterend', sectionRewards) | ||
| sectionRewards.insertAdjacentElement('afterend', sectionSocialBlocking) | ||
| } else { | ||
| sectionShields.insertAdjacentElement('afterend', sectionSocialBlocking) | ||
| last = last.insertAdjacentElement('afterend', sectionShields) | ||
| // Insert Rewards | ||
| if (sectionRewards) { | ||
| last = last.insertAdjacentElement('afterend', sectionRewards) | ||
| } | ||
| // Insert Social Blocking | ||
| last = last.insertAdjacentElement('afterend', sectionSocialBlocking) | ||
| // Move privacy section to after social blocking | ||
| const sectionPrivacy = getSectionElement(actualTemplate.content, 'privacy') | ||
| sectionSocialBlocking.insertAdjacentElement('afterend', sectionPrivacy) | ||
| last = last.insertAdjacentElement('afterend', sectionPrivacy) | ||
| // Insert sync | ||
| sectionPrivacy.insertAdjacentElement('afterend', sectionSync) | ||
| last = last.insertAdjacentElement('afterend', sectionSync) | ||
| // Move search | ||
| const sectionSearch = getSectionElement(actualTemplate.content, 'search') | ||
| sectionSync.insertAdjacentElement('afterend', sectionSearch) | ||
| last = last.insertAdjacentElement('afterend', sectionSearch) | ||
| // Insert extensions | ||
| sectionSearch.insertAdjacentElement('afterend', sectionExtensions) | ||
| // Insert Wallet and IPFS | ||
| if (isBraveWalletAllowed) { | ||
| sectionExtensions.insertAdjacentElement('afterend', sectionWallet) | ||
| sectionWallet.insertAdjacentElement('afterend', sectionIPFS) | ||
| } else { | ||
| sectionExtensions.insertAdjacentElement('afterend', sectionIPFS) | ||
| last = last.insertAdjacentElement('afterend', sectionExtensions) | ||
| // Insert Wallet | ||
| if (sectionWallet) { |
| const ipfsEl = createMenuElement( | ||
| loadTimeData.getString('braveIPFS'), | ||
| '/ipfs', | ||
| 'brave_settings:ipfs', |
There was a problem hiding this comment.
I think this means we should remove the ipfs icon from brave_settings unless we show it anywhere else?
supermassive
force-pushed
the
web3_settings_section
branch
from
5ed2124 to
46486a1
Compare
|
A Storybook has been deployed to preview UI for the latest push |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14516
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
Wallet networksshould workIpfs peersandIpns keysshould workbrave_i0H11W9s7D.mp4