Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added select theme UI to the new onboarding flow uplift to 1.47.x #16420

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Dec 20, 2022

Uplift of #16326
Resolves brave/brave-browser#27170

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@nullhook nullhook requested a review from a team as a code owner December 20, 2022 06:19
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Dec 20, 2022
@nullhook nullhook force-pushed the onboarding-select-theme-1.47.x branch from 18f164c to 2cb625e Compare December 21, 2022 08:57
@kjozwiak
Copy link
Member

@nullhook mind taking a look? Looks like Win, macOS and Linux are failing due to components\brave_welcome_ui\components\select-theme\style.ts failing as per the following:

[2022-12-21T09:34:11.132Z] 
[2022-12-21T09:34:11.132Z] > brave-core@1.47.138 eslint
[2022-12-21T09:34:11.132Z] > eslint -c .eslintrc.json ./components
[2022-12-21T09:34:11.132Z] 
[2022-12-21T09:34:44.379Z] 
[2022-12-21T09:34:44.379Z] C:\ws\src\brave\components\brave_welcome_ui\components\select-theme\style.ts
[2022-12-21T09:34:44.379Z]   1:1  error  incorrect license  licenses/header
[2022-12-21T09:34:44.379Z] 
[2022-12-21T09:34:44.379Z] ✖ 1 problem (1 error, 0 warnings)
[2022-12-21T09:34:44.379Z]   1 error and 0 warnings potentially fixable with the `--fix` option.
[2022-12-21T09:34:44.379Z] 
script returned exit code 1

@nullhook nullhook force-pushed the onboarding-select-theme-1.47.x branch from 2cb625e to 9bffe3e Compare December 23, 2022 02:10
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@kjozwiak kjozwiak added this to the 1.47.x - Beta milestone Dec 29, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.47.x approved 👍 QA has verified the PR on Nightly as per #16326 (comment).

@kjozwiak kjozwiak merged commit 86ac530 into 1.47.x Dec 29, 2022
@kjozwiak kjozwiak deleted the onboarding-select-theme-1.47.x branch December 29, 2022 14:43
@github-actions
Copy link
Contributor

⚠️ PR head is an unsigned commit
commit: 9bffe3e
reason: unsigned
Please follow the handbook to configure commit signing
cc: @nullhook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants