Wallet address resolution for Android #16423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supermassive
commented
Dec 20, 2022
Comment on lines
+1211
to
+1240
| if (WalletNativeUtils.isUnstoppableDomainsTld(domain)) { | ||
| mJsonRpcService.unstoppableDomainsGetWalletAddr( | ||
| domain, mCurrentBlockchainToken, (response, errorResponse, errorString) -> { | ||
| onResolveWalletAddressDone(domain, response); | ||
| }); | ||
| return true; | ||
| } | ||
|
|
||
| if (mCurrentBlockchainToken.coin == CoinType.ETH && WalletNativeUtils.isEnsTld(domain)) { | ||
| mJsonRpcService.ensGetEthAddr(domain, null, | ||
| (response, requireOffchainConsent, errorResponse, errorString) -> { | ||
| onResolveWalletAddressDone(domain, response); | ||
| }); | ||
| return true; | ||
| } | ||
|
|
||
| if (ChromeFeatureList.isEnabled(BraveFeatureList.BRAVE_WALLET_SNS)) { | ||
| if (mCurrentBlockchainToken.coin == CoinType.SOL | ||
| && WalletNativeUtils.isSnsTld(domain)) { | ||
| mJsonRpcService.snsGetSolAddr(domain, (response, errorResponse, errorString) -> { | ||
| onResolveWalletAddressDone(domain, response); | ||
| }); | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| mResolvedAddrText.setVisibility(View.GONE); | ||
| mResolvedAddrText.setText(""); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Eventually will be refactored to a single mojo call brave/brave-browser#26655
|
|
| if (result == null || result.isEmpty()) { | ||
| mResolvedAddrText.setVisibility(View.GONE); | ||
| mResolvedAddrText.setText(""); | ||
| String notRegsteredErrorText = String.format( |
There was a problem hiding this comment.
notRegsteredErrorText -> notRegisteredErrorText
| } | ||
|
|
||
| if (ChromeFeatureList.isEnabled(BraveFeatureList.BRAVE_WALLET_SNS)) { | ||
| if (mCurrentBlockchainToken.coin == CoinType.SOL |
There was a problem hiding this comment.
could be combined to a single if
There was a problem hiding this comment.
This is supposed to be a temporary feature and to be removed as soon as our backend is ready. While inner if block matches pattern above
SergeyZhukovsky
approved these changes
Dec 20, 2022
yrliou
reviewed
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#27464
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
untitled.webm