Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Lock wallet text case #16649

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Updated the Lock wallet text to be sentence-case

Resolves brave/brave-browser#27571

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Go to the Portfolio page
  2. Click on the more icon
  3. Should show Lock wallet not Lock Wallet

Before:

Screenshot 2023-01-12 at 2 25 21 PM

After:

Screenshot 2023-01-12 at 2 27 13 PM

@Douglashdaniel Douglashdaniel requested a review from a team as a code owner January 12, 2023 20:37
@Douglashdaniel Douglashdaniel self-assigned this Jan 12, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 12, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel merged commit 3317161 into master Jan 13, 2023
@Douglashdaniel Douglashdaniel deleted the fix-lock-wallet-text-case branch January 13, 2023 04:31
@github-actions github-actions bot added this to the 1.49.x - Nightly milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Lock Wallet' -- > 'Lock wallet'
3 participants