Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on Permissions dialog #16681

Merged
merged 1 commit into from
Jan 14, 2023
Merged

Crash on Permissions dialog #16681

merged 1 commit into from
Jan 14, 2023

Conversation

sujitacharya2005
Copy link
Contributor

@sujitacharya2005 sujitacharya2005 commented Jan 14, 2023

Resolves brave/brave-browser#27810
Resolves brave/brave-browser#27808
Resolves brave/brave-browser#27809

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

All these above crash due to called from onNewIntent some of the inititializations are not done.

  1. Now reverting this method from onNewIntent, This method is only called from finishNativeInitialization.
  2. Now this method will call when application close from recent and launched again.

@sujitacharya2005 sujitacharya2005 added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 14, 2023
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya deeppandya added this to the 1.49.x - Nightly milestone Jan 14, 2023
@deeppandya deeppandya force-pushed the 27810_Crash_Notification branch from f63126a to 0b11044 Compare January 14, 2023 22:10
@deeppandya deeppandya enabled auto-merge January 14, 2023 22:11
@deeppandya deeppandya merged commit f5cff81 into master Jan 14, 2023
@deeppandya deeppandya deleted the 27810_Crash_Notification branch January 14, 2023 22:44
brave-builds added a commit that referenced this pull request Jan 14, 2023
brave-builds added a commit that referenced this pull request Jan 14, 2023
@kjozwiak
Copy link
Member

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.49.30 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 12; Build/SP1A.210812.016

Went through the STR/Cases outlined via #16128 (comment) & #16651 (comment) and ensured everything was working as expected without any issues.


Verification PASSED on Pixel 6+ running Android 13 using the following build(s):

Brave | 1.49.30 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/T2B2.221216.006

Went through the STR/Cases outlined via #16128 (comment) & #16651 (comment) and ensured everything was working as expected without any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on permissions Crash related to notification warning dialog Crash related to ads notifications
4 participants