-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on Permissions dialog #16681
Crash on Permissions dialog #16681
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f63126a
to
0b11044
Compare
Verification PASSED on
Went through the STR/Cases outlined via #16128 (comment) & #16651 (comment) and ensured everything was working as expected without any issues. Verification PASSED on
Went through the STR/Cases outlined via #16128 (comment) & #16651 (comment) and ensured everything was working as expected without any issues. |
Resolves brave/brave-browser#27810
Resolves brave/brave-browser#27808
Resolves brave/brave-browser#27809
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
All these above crash due to called from onNewIntent some of the inititializations are not done.