Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable_pdfjs-extension switch #168

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Add --disable_pdfjs-extension switch #168

merged 1 commit into from
Jun 13, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 13, 2018

Fix brave/brave-browser#335

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bbondy bbondy self-assigned this Jun 13, 2018
@bbondy bbondy requested a review from yrliou June 13, 2018 04:51
@bbondy bbondy merged commit 3c0328c into master Jun 13, 2018
@bsclifton bsclifton deleted the disable-pdfjs branch June 18, 2018 06:28
NejcZdovc added a commit that referenced this pull request Dec 10, 2018
Splits contribution flow into separate file
NejcZdovc added a commit that referenced this pull request Dec 11, 2018
Splits contribution flow into separate file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants