Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] fix brave news v2 rss crash #16801

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

tapanmodh
Copy link
Contributor

@tapanmodh tapanmodh commented Jan 23, 2023

Resolves brave/brave-browser#27952

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. open brave://flags
  2. tap to Enable Brave News v2
  3. tap to Relaunch Brave
  4. tap the 3-dots menu
  5. tap Settings -> Brave News or Brave News, top-level menu item
  6. enter pravda.com.ua into the Search for site, topic or RSS feed textfield
  7. tap Get Feeds
  8. It should not crash and displays list of rss items from that site
23-01-24-00-28-52.mp4

@tapanmodh tapanmodh added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 23, 2023
@tapanmodh tapanmodh added this to the 1.49.x - Nightly milestone Jan 23, 2023
@tapanmodh tapanmodh self-assigned this Jan 23, 2023
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya
Copy link
Contributor

@tapanmodh were you able to reproduce the crash on your device ?

@tapanmodh
Copy link
Contributor Author

@tapanmodh were you able to reproduce the crash on your device ?

yes, I was able to reproduce the crash.

@tapanmodh tapanmodh merged commit 32e6c17 into master Jan 24, 2023
@tapanmodh tapanmodh deleted the fix_brave_news_v2_rss_crash_android branch January 24, 2023 05:39
brave-builds added a commit that referenced this pull request Jan 24, 2023
@stephendonner
Copy link
Contributor

Verified PASSED using Brave 1.49.57, Chromium 109.0.5414.87

Followed my original steps to reproduce: brave/brave-browser#27952 (comment)

NOTE: The scope of this issue is around the RSS-feed results for pravda.com.ua crashing search, which no longer does. I'll file a new issue for the inability to subscribe (looks like out-of-memory similar) due to the UI freezing.

Confirmed returning RSS-feed results from a pravda.com.ua search no longer crashes

Screencast:

20230124_135353.mp4

@stephendonner
Copy link
Contributor

NOTE: The scope of this issue is around the RSS-feed results for pravda.com.ua crashing search, which no longer does. I'll file a new issue for the inability to subscribe (looks like out-of-memory similar) due to the UI freezing.

Logged brave/brave-browser#28021 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when trying to add pravda.com.ua RSS feed into Brave News v2
3 participants