Youtube videos with custom paths now show correctly #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
Feb 18, 2019
NejcZdovc
reviewed
Feb 18, 2019
NejcZdovc
reviewed
Feb 18, 2019
NejcZdovc
reviewed
Feb 18, 2019
NejcZdovc
previously requested changes
Feb 19, 2019
There was a problem hiding this comment.
verified icon is not displayed.
- run browser with production flag
- enable rewards
- go to google.com
- search for
Bart Bakerand click on link https://www.youtube.com/BartBaKer - click on panel
- you will first see his image then the image will be gone
|
|
|
@jasonrsadler please rebase |
|
Done |
|
@jasonrsadler please rebase |
NejcZdovc
reviewed
Feb 22, 2019
NejcZdovc
reviewed
Feb 22, 2019
NejcZdovc
previously approved these changes
Feb 22, 2019
Fix linting Update to ensure that custom channel that begins with yt designate is shown correctly Moved predefined youtube paths to media file. Added unit tests Added additional edge cases
NejcZdovc
approved these changes
Feb 22, 2019
NejcZdovc
pushed a commit
that referenced
this pull request
Mar 6, 2019
Youtube videos with custom paths now show correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#1886
Requires #1764 as well
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Open clean profile Brave and enable Rewards.
Visit a Youtube channel with a custom path
(https://www.youtube.com/bravesoftware)
(https://www.youtube.com/nba)
(https://www.youtube.com/nfl)
Make sure the publisher panel shows the right publisher
Visit publisher video channels without a custom path and make sure they still appear properly
Visit a youtube designated path
(https://www.youtube.com/gaming)
(https://www.youtube.com/reporthistory)
(https://www.youtube.com/account)
(https://www.youtube.com/feed/trending)
and make sure that youtube.com is shown for publisher.
Visit a custom channel that begins with a youtube designated path
(https://youtube.com/gaminggiant)
(https://www.youtube.com/feedme)
and make sure correct publisher is shown
Create a playlist then open the hb menu and select that playlist and make sure youtube.com is shown for publisher
Visit verified publisher video channels with custom path and make sure favicon shows in panel
(https://www.youtube.com/bravesoftware)
(https://www.youtube.com/bartbaker)
Reviewer Checklist: