Fixes include/excluded update in the panel #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
include-switch
branch
3 times, most recently
from
8606c66 to
37606b2
Compare
| @@ -10,6 +10,7 @@ | |||
| #include <map> | |||
| #include <memory> | |||
| #include <string> | |||
| #include <utility> | |||
There was a problem hiding this comment.
Is this for something in this PR or something else?
There was a problem hiding this comment.
this fixes linter error
jasonrsadler
previously requested changes
Feb 27, 2019
There was a problem hiding this comment.
ac list isn't populating:
- Start Brave and enable rewards
- Tear off second tab and have rewards dashboard in background
- Go to brave.com for the required amount of time
- Notice it doesn't show up in rewards screen
- Open panel on brave.com tab and exclude the site
- Notice dashboard says 1 site excluded
- Open panel on brave.com and include site
- Site still does not appear
After required amount of time:
After excluding using panel:
After including again:
|
@jasonrsadler so code didn't changed for adding stuff to ac table. Could you please test it on master and see if you see the same problem? I can't reproduce this problem |
NejcZdovc
dismissed
jasonrsadler’s stale review
I can't reproduce. Can you please check again?
|
Yes, that seems to be a separate issue outside this PR |
|
@NejcZdovc can you rebase |
NejcZdovc
force-pushed
the
include-switch
branch
from
71a44f7 to
4c0698b
Compare
jasonrsadler
approved these changes
Feb 28, 2019
NejcZdovc
added a commit
that referenced
this pull request
Mar 1, 2019
Fixes include/excluded update in the panel
NejcZdovc
added a commit
that referenced
this pull request
Mar 1, 2019
Fixes include/excluded update in the panel
This was referenced Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#3480
Resolves brave/brave-browser#3476
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: