Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trap and report error when hostname is null/empty #17917

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Apr 4, 2023

Fixes brave/brave-browser#28940
Fixes brave/brave-browser#29502
Fixes brave/brave-browser#29477

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@MadhaviSeelam can reproduce; I think we need her to try

@bsclifton bsclifton self-assigned this Apr 4, 2023
@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-linux-arm64 labels Apr 4, 2023
@bsclifton
Copy link
Member Author

Issues discovered by @MadhaviSeelam and shared on employee Slack here:
https://bravesoftware.slack.com/archives/C021S0FN3V1/p1680565130321449

@bsclifton bsclifton merged commit a421140 into master Apr 5, 2023
@bsclifton bsclifton deleted the bsc-fix-vpn-windows-crash branch April 5, 2023 00:33
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 5, 2023
@MadhaviSeelam
Copy link

Verified using

Brave | 1.52.18 Chromium: 112.0.5615.49 (Developer Build) (64-bit)
-- | --
Revision | bd2a7bcb881c11e8cfe3078709382934e3916914-refs/branch-heads/5615@{#936}
OS | Windows 11 Version 22H2 (Build 22621.1413)

image

@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2023

@MadhaviSeelam also added verification notes via #17919 (comment) using a 1.50.x build that @bsclifton provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
4 participants