-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SCT enforcement #17944
Merged
Merged
Enable SCT enforcement #17944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
2 times, most recently
from
April 6, 2023 04:02
be0d8b1
to
63012dd
Compare
fmarier
added
the
CI/run-upstream-tests
Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
label
Apr 6, 2023
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
5 times, most recently
from
April 13, 2023 23:17
f329e35
to
2754161
Compare
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
from
April 17, 2023 19:01
2754161
to
4838bb9
Compare
fmarier
removed
the
CI/run-upstream-tests
Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
label
Apr 17, 2023
Note: the test page is not yet live (https://github.com/brave/devops/issues/9497), but the approach is ready for review. I will wait for that test page to be live before merging. Also, CI is not passing yet, but from what I can see it's not caused by changes in this PR. I will investigate more once CI is more stable. It sounds like many PRs are affected at the moment. |
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
from
April 18, 2023 07:08
4838bb9
to
726310f
Compare
goodov
reviewed
Apr 18, 2023
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
3 times, most recently
from
May 5, 2023 19:14
60e94b6
to
4b2f9de
Compare
fmarier
commented
May 5, 2023
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
from
May 5, 2023 23:17
4b2f9de
to
e92356c
Compare
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
from
May 8, 2023 23:51
e92356c
to
467e07e
Compare
goodov
approved these changes
May 15, 2023
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
3 times, most recently
from
May 19, 2023 04:00
85a3ffa
to
2b13f4b
Compare
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates. It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
fmarier
force-pushed
the
enable-sct-enforcement-22482
branch
from
May 19, 2023 18:22
2b13f4b
to
cf63b4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Brave follow the same Certificate Transparency policy as Chrome for TLS certificates.
It also excludes Brave hostnames which are involved with browser updates in order to ensure that updates always work even if the certificate transparency code breaks in the future.
Resolves brave/brave-browser#22482
Security review: https://github.com/brave/security/issues/1245
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Follow these steps on desktop and Android:
NET::ERR_CERTIFICATE_TRANSPARENCY_REQUIRED
).NET::ERR_CERTIFICATE_TRANSPARENCY_REQUIRED
).