Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more detailed log to VPN api on Windows #17946

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Apr 6, 2023

issue brave/brave-browser#29512

No functional change.
To know exactly which Ras API causes last error.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-linux-arm64 labels Apr 6, 2023
@simonhong simonhong requested a review from bsclifton April 6, 2023 02:17
@simonhong simonhong self-assigned this Apr 6, 2023
@simonhong simonhong force-pushed the add_more_logs_to_vpn_win_api branch from 8cae4fa to 4c42cb3 Compare April 6, 2023 02:39
@bsclifton bsclifton force-pushed the add_more_logs_to_vpn_win_api branch 2 times, most recently from 8725719 to e8fe5ad Compare April 6, 2023 05:32
@bsclifton bsclifton force-pushed the add_more_logs_to_vpn_win_api branch from e8fe5ad to d10fdc1 Compare April 6, 2023 05:37
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@simonhong simonhong merged commit 5de7680 into master Apr 6, 2023
@simonhong simonhong deleted the add_more_logs_to_vpn_win_api branch April 6, 2023 07:23
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants