Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passed phonebook path for ras api instead of NULL #17964

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

simonhong
Copy link
Member

fix brave/brave-browser#29512

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@simonhong simonhong added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-linux-arm64 labels Apr 7, 2023
@simonhong simonhong requested a review from bsclifton April 7, 2023 06:11
@simonhong simonhong self-assigned this Apr 7, 2023
@@ -180,7 +179,7 @@ std::wstring GetPhonebookPath(const std::wstring& entry_name,
return path;
}

*error = "failed to get phonebook path from ALLUSERSPROFILE";
*error = "failed to get phonebook path from ALLUSERSPROFILE and APPDATA";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix here 😄

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will fix the weird problems we've seen! Definitely I know from experience it can write to both directories - and it seems DEFAULT_PHONE_BOOK can change depending on circumstances. I think last time, @MadhaviSeelam had restarted after the file existed and it fixed the issue (it seemed to move the ALL PROFILES to her regular profile after reboot). Specifying the path is a great solution for this! 😄

@simonhong simonhong enabled auto-merge April 7, 2023 07:46
@simonhong simonhong merged commit 20d8969 into master Apr 7, 2023
@simonhong simonhong deleted the vpn_entry_creation_failure_windows branch April 7, 2023 09:20
@github-actions github-actions bot added this to the 1.52.x - Nightly milestone Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect failed with Failed to write the VPN config
2 participants