Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave UI sha #1819

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Update Brave UI sha #1819

merged 2 commits into from
Mar 7, 2019

Conversation

rossmoody
Copy link
Contributor

This points to the latest commit in brave-core-0.63.x branch in Brave UI.

Closes: brave/brave-browser#3487
Closes: brave/brave-browser#3483
Closes: brave/brave-browser#3218

Brave UI PRs

brave/brave-ui#391
brave/brave-ui#393
brave/brave-ui#394

@ryanml
Copy link
Contributor

ryanml commented Mar 1, 2019

@rossmoody we should also update the hashes for brave-ui in package-lock.json

https://github.com/brave/brave-core/blob/master/package-lock.json#L1333

Those old ones can just be swapped out

@petemill
Copy link
Member

petemill commented Mar 4, 2019

When making these PRs, we have sometimes been linking to what's changed between old and previous: brave/brave-ui@c69fba4...3a0b168

@NejcZdovc NejcZdovc merged commit e393074 into master Mar 7, 2019
@NejcZdovc NejcZdovc deleted the ui-sha branch March 7, 2019 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants