Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brave Ads CHECKs in invalid data paths #19069

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Fix Brave Ads CHECKs in invalid data paths #19069

merged 1 commit into from
Jun 28, 2023

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Jun 27, 2023

Resolves brave/brave-browser#31105

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

No testing is required because Brave Ads logic wasn't changed.

@aseren aseren requested a review from a team as a code owner June 27, 2023 16:00
@aseren aseren force-pushed the issues/31105 branch 3 times, most recently from 9aa4ac4 to ac8bd33 Compare June 27, 2023 20:20
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aseren aseren force-pushed the issues/31105 branch 2 times, most recently from 3375447 to 02c40f7 Compare June 28, 2023 16:39
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@aseren aseren enabled auto-merge June 28, 2023 21:58
@aseren aseren merged commit fe94c09 into master Jun 28, 2023
@aseren aseren deleted the issues/31105 branch June 28, 2023 23:21
@github-actions github-actions bot added this to the 1.55.x - Nightly milestone Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Brave Ads CHECKs in invalid data paths
2 participants