Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "Open in playlist" from PlaylistActionBubbleView #19244

Merged
merged 4 commits into from
Jul 14, 2023
Merged

Implement "Open in playlist" from PlaylistActionBubbleView #19244

merged 4 commits into from
Jul 14, 2023

Conversation

sangwoo108
Copy link
Contributor

Resolves brave/brave-browser#31581

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jul 12, 2023
@sangwoo108 sangwoo108 force-pushed the sko/pl-bubble-open branch from ccf208f to f43a811 Compare July 12, 2023 05:20
@sangwoo108 sangwoo108 added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jul 12, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@sangwoo108 sangwoo108 marked this pull request as ready for review July 12, 2023 11:09
@sangwoo108 sangwoo108 force-pushed the sko/pl-bubble-open branch from f43a811 to b3a6e33 Compare July 13, 2023 11:24
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

simonhong
simonhong approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browser/ui/views/ ++

@sangwoo108 sangwoo108 force-pushed the sko/pl-bubble-open branch from 8bb6683 to bb70d20 Compare July 14, 2023 01:24
@sangwoo108 sangwoo108 force-pushed the sko/pl-bubble-open branch from bb70d20 to 5a047ea Compare July 14, 2023 01:25
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

fallaciousreasoning
fallaciousreasoning approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sangwoo108 sangwoo108 merged commit 6a5e4f0 into master Jul 14, 2023
@sangwoo108 sangwoo108 deleted the sko/pl-bubble-open branch July 14, 2023 03:22
@github-actions github-actions bot added this to the 1.58.x - Nightly milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fallaciousreasoning fallaciousreasoning fallaciousreasoning approved these changes

@simonhong simonhong simonhong approved these changes

Assignees

@sangwoo108 sangwoo108

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging this pull request may close these issues.

"Open in playlist" from PlaylistActionBubbleView
4 participants
@sangwoo108 @brave-builds @simonhong @fallaciousreasoning