Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update brave-ui sha for shields #1931

Merged
merged 1 commit into from
Mar 13, 2019
Merged

update brave-ui sha for shields #1931

merged 1 commit into from
Mar 13, 2019

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Mar 13, 2019

@petemill
Copy link
Member

This is the comparison of before and after: brave/brave-ui@b714fc0...9568cc9.

Seems to bring in color palette changes as well as shields changes.

@petemill
Copy link
Member

@cezaraugusto we need an issue for this so that people can see what this brave-ui update is bringing

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - compiles, works and fixes build error as a result of #1797
Please add brave-browser issue if you can @cezaraugusto

@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Mar 13, 2019

added and closed brave/brave-browser#3704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update brave-ui sha to include the new Shields work
2 participants