-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Widevine signature_generator to Python 3 #19437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
CI/run-audit-deps
Check for known npm/cargo vulnerabilities (audit_deps)
potential-layer-violation-fixes
This PR touches a BUILD.gn file with check_includes=false
labels
Jul 26, 2023
mherrmann
force-pushed
the
signature_generator_py3
branch
from
July 26, 2023 16:50
d98ff1e
to
d0af371
Compare
mherrmann
requested review from
fmarier,
simonhong,
a team and
bridiver
as code owners
July 26, 2023 18:07
@fmarier @simonhong can I please ask for your reviews? The only differences to #18636 are in |
bridiver
approved these changes
Jul 26, 2023
fmarier
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script/brave_license_helper.py
👍
simonhong
approved these changes
Jul 26, 2023
mherrmann
added a commit
that referenced
this pull request
Aug 11, 2023
Uplift of #19437 into v1.57.x.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CI/run-audit-deps
Check for known npm/cargo vulnerabilities (audit_deps)
needs-security-review
potential-layer-violation-fixes
This PR touches a BUILD.gn file with check_includes=false
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had to revert #18636 because
init
failed on Arm64 macOS with the output below.Error output
This PR contains the same changes as #18636, except for improved logic in DEPS.