-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds notification for when tips are processed #1959
Conversation
0931194
to
f326dd0
Compare
"description": "Message for monthly tips processed notification" | ||
}, | ||
"contributionTips": { | ||
"message": "Contributions & Tips", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to Contributions & Tips
per @mandar-brave
842fdf9
to
bb62ae9
Compare
8fb5bf4
to
77a2b2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you please change to BindOnce
in brave_rewards_api
for BraveRewardsGetACEnabledFunction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NejcZdovc test plan worked fine for me, could you maybe list your steps to that path? |
@NejcZdovc rebased, using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please verify linter
@NejcZdovc C++ lint fixed |
Fixes: brave/brave-browser#3637
UI: brave/brave-ui#429
The intention is that when AutoContribute is off, that we notify the user when their recurring tips have processed.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist: