Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds notification for when tips are processed #1959

Merged
merged 1 commit into from
Mar 29, 2019
Merged

Adds notification for when tips are processed #1959

merged 1 commit into from
Mar 29, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Mar 15, 2019

Fixes: brave/brave-browser#3637
UI: brave/brave-ui#429

The intention is that when AutoContribute is off, that we notify the user when their recurring tips have processed.

Screen Shot 2019-03-14 at 5 33 26 PM

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave and enable Rewards
  2. Claim a grant, turn off auto contribute
  3. Make some monthly tips to different publishers
  4. Wait a month (or set your reconcile stamp back to something reasonable)
  5. Ensure that the notification showing that tips have been processed is in the panel after reconcile is finished.
  6. Repeat the steps with auto contribute on, and ensure the notification does not show

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@ryanml ryanml added this to the 0.64.x - Nightly milestone Mar 15, 2019
@ryanml ryanml self-assigned this Mar 15, 2019
@ryanml ryanml force-pushed the fix-3637 branch 2 times, most recently from 0931194 to f326dd0 Compare March 15, 2019 02:44
ryanml
ryanml commented Mar 15, 2019
View reviewed changes
components/brave_rewards/resources/extension/brave_rewards/_locales/en_US/messages.json
"description": "Message for monthly tips processed notification"
},
"contributionTips": {
"message": "Contributions & Tips",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to Contributions & Tips per @mandar-brave

@ryanml ryanml force-pushed the fix-3637 branch 3 times, most recently from 842fdf9 to bb62ae9 Compare March 20, 2019 03:27
@ryanml ryanml requested a review from NejcZdovc March 20, 2019 03:28
@ryanml ryanml mentioned this pull request Mar 20, 2019
Merged
9 tasks
@ryanml ryanml force-pushed the fix-3637 branch 2 times, most recently from 8fb5bf4 to 77a2b2f Compare March 22, 2019 05:44
NejcZdovc
NejcZdovc reviewed Mar 25, 2019
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can you please change to BindOnce in brave_rewards_api for BraveRewardsGetACEnabledFunction

NejcZdovc
NejcZdovc previously requested changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notification was not shown for me

image

@ryanml
Copy link
Contributor Author

ryanml commented Mar 26, 2019

@NejcZdovc test plan worked fine for me, could you maybe list your steps to that path?

Screen Shot 2019-03-26 at 3 38 55 PM

@ryanml
Copy link
Contributor Author

ryanml commented Mar 26, 2019

@NejcZdovc rebased, using BindOnce now in BraveRewardsGetACEnabledFunction

@ryanml ryanml requested a review from NejcZdovc March 26, 2019 22:48
@NejcZdovc NejcZdovc dismissed their stale review March 27, 2019 05:29

working now

NejcZdovc
NejcZdovc previously requested changes Mar 27, 2019
View reviewed changes
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please verify linter

@ryanml ryanml requested a review from NejcZdovc March 27, 2019 08:27
@ryanml
Copy link
Contributor Author

ryanml commented Mar 27, 2019

@NejcZdovc C++ lint fixed

@ryanml ryanml merged commit 839f85f into master Mar 29, 2019
@ryanml ryanml deleted the fix-3637 branch March 29, 2019 10:53
@btlechowski btlechowski mentioned this pull request Apr 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

@jasonrsadler jasonrsadler Awaiting requested review from jasonrsadler

Assignees

@ryanml ryanml

Labels
feature/rewards
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.

add notification for monthly tip contribution
2 participants
@ryanml @NejcZdovc