Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Brave News]: Implement basic version of new Feed Building logic #19664

Merged
merged 19 commits into from
Aug 16, 2023
Merged

[Brave News]: Implement basic version of new Feed Building logic #19664

merged 19 commits into from
Aug 16, 2023

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Aug 14, 2023 •
edited
Loading

Resolves brave/brave-browser#32174

Screencast.from.2023-08-15.15-46-37.webm

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Aug 14, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning requested review from sangwoo108 and petemill and removed request for sangwoo108 August 15, 2023 03:45
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

sangwoo108
sangwoo108 approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a few nits. Nice work!

components/brave_news/browser/signal_calculator.h Outdated Show resolved Hide resolved
components/brave_news/browser/signal_calculator.cc Outdated Show resolved Hide resolved
components/brave_news/browser/signal_calculator.cc Outdated Show resolved Hide resolved
components/brave_news/browser/signal_calculator.cc Outdated Show resolved Hide resolved
components/brave_news/browser/signal_calculator.cc Outdated Show resolved Hide resolved
components/brave_news/browser/feed_v2_builder.cc Outdated Show resolved Hide resolved
components/brave_news/browser/feed_v2_builder.cc Show resolved Hide resolved
components/brave_news/browser/feed_v2_builder.cc Outdated Show resolved Hide resolved
components/brave_news/browser/feed_v2_builder.cc
auto block = GenerateBlock(allowed_articles);

// Put the unused articles back in the original list.
base::ranges::move(allowed_articles, std::back_inserter(articles));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using your tips 😆

components/brave_news/browser/feed_v2_builder.cc Outdated Show resolved Hide resolved
@fallaciousreasoning
Copy link
Contributor Author

Thanks for the super helpful (as always!) review @sangwoo108!

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@fallaciousreasoning fallaciousreasoning merged commit 91b702d into master Aug 16, 2023
6 checks passed
@fallaciousreasoning fallaciousreasoning deleted the bn-feed-building branch August 16, 2023 03:14
@github-actions github-actions bot added this to the 1.59.x - Nightly milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangwoo108 sangwoo108 sangwoo108 approved these changes

@petemill petemill Awaiting requested review from petemill

@LorenzoMinto LorenzoMinto Awaiting requested review from LorenzoMinto

@aurangzaib048 aurangzaib048 Awaiting requested review from aurangzaib048

Assignees

@fallaciousreasoning fallaciousreasoning

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging this pull request may close these issues.

[Brave News]: Implement new feed generation
3 participants
@fallaciousreasoning @brave-builds @sangwoo108