Native ledger integration #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
force-pushed
the
native-ledger
branch
2 times, most recently
from
25ba1d5
to
7e2797c
Compare
gdregalo
previously approved these changes
Jul 3, 2018
bbondy
force-pushed
the
native-ledger
branch
8 times, most recently
from
f391dbd
to
45cfecb
Compare
bridiver
reviewed
Jul 6, 2018
|
|
||
| // TODO(bbondy): Use an observer or client override for when the wallet is actually | ||
| // created once the native-ledger library supports it. | ||
| OnWalletCreated(); |
There was a problem hiding this comment.
I know this is temporary, but seems like we should have some kind of message if payments_service is null (windows)?
There was a problem hiding this comment.
Added OnWalletCreateFailed
Adds the ability both to notify the webui of when a wallet is created and the ability for the webui to call a function to create wallets too
bridiver
approved these changes
Jul 6, 2018
NejcZdovc
pushed a commit
that referenced
this pull request
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency hashes need to be adjusted once https://github.com/brave-intl/bat-native-ledger/pull/3/files and related pull requests land.
Fix brave/brave-browser#473
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: