Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always waiting for user interaction to fill the password form in Brave #2003

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Mar 18, 2019

instead of using kFillOnAccountSelect which will show suggestions on page load
Untitled
fix brave/brave-browser#1713

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Use built-in password manager to store credentials for twitter
  2. Go to twitter.com
  3. There is no password suggestions nor automatically filled password on page load
  4. Click on username/password filed to show suggestions

  1. Go to https://senglehardt.com/demo/no_boundaries/loginmanager/index.html
  2. Save fake credentials
  3. Follow the instructions of the website
  4. The result should be Sniffed email: ? Sniffed password: ?

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@darkdh darkdh self-assigned this Mar 18, 2019
bbondy
bbondy previously approved these changes Mar 19, 2019
instead of using kFillOnAccountSelect which will show suggestions on page load
@diracdeltas
Copy link
Member

lgtm

@bsclifton
Copy link
Member

Nice!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login autofill popup appears unexpectedly in odd location upon page load
5 participants