Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert PR #1943 and #2035 #2058

Merged
merged 2 commits into from
Mar 25, 2019
Merged

Revert PR #1943 and #2035 #2058

merged 2 commits into from
Mar 25, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Mar 25, 2019 •
edited
Loading

Fix brave/brave-browser#3883

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@yrliou yrliou self-assigned this Mar 25, 2019
@yrliou yrliou added this to the 0.64.x - Nightly milestone Mar 25, 2019
@yrliou
Copy link
Member Author

yrliou commented Mar 25, 2019

Need to uplift to dev too.

@yrliou yrliou merged commit 9f10c0c into master Mar 25, 2019
@yrliou yrliou mentioned this pull request Mar 25, 2019
Merged
@yrliou yrliou deleted the revert_pr_1943_and_2035 branch March 26, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

@tmancey tmancey Awaiting requested review from tmancey

@emerick emerick Awaiting requested review from emerick

Assignees

@yrliou yrliou

Labels
None yet
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.

Rewards browser test failed
2 participants
@yrliou @bbondy